lkml.org 
[lkml]   [2015]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 11/25] ARM/dmaengine: edma: Merge the two drivers under drivers/dma/
On Thu, Sep 24, 2015 at 01:01:58PM +0300, Peter Ujfalusi wrote:
> Move the code out from arch/arm/common and merge it inside of the dmaengine
> driver.
> This change is done with as minimal change to the code as possible to avoid
> any possibilities to introducing regression.

Is this a pure move patch or code has been modified, if latter am
disappointed that existing code style issue have not been fixed


> +static inline void edma_write(struct edma_cc *ecc, int offset, int val)
> +{
> + __raw_writel(val, ecc->base + offset);
> +}
> +static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
> + unsigned or)

This looks bad on my 80 char screen, and few more places below

> +{
> + unsigned val = edma_read(ecc, offset);

checkpatch should have asked you to add empty line here, many places below
too

> + val &= and;
> + val |= or;
> + edma_write(ecc, offset, val);
> +}

empty line here and few more places

More later :)

--
~Vinod


\
 
 \ /
  Last update: 2015-10-12 18:21    [W:1.409 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site