lkml.org 
[lkml]   [2015]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 9/9] eeprom: at24: readability tweaks
    Date
    Move the macro definitions above the struct definitions and add some
    tabs for better readability.

    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    ---
    drivers/misc/eeprom/at24.c | 16 ++++++++--------
    1 file changed, 8 insertions(+), 8 deletions(-)

    diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
    index 52875f4..0f873db 100644
    --- a/drivers/misc/eeprom/at24.c
    +++ b/drivers/misc/eeprom/at24.c
    @@ -52,6 +52,14 @@
    * which won't work on pure SMBus systems.
    */

    +#define AT24_SIZE_BYTELEN 5
    +#define AT24_SIZE_FLAGS 8
    +
    +#define AT24_BITMASK(x) (BIT(x) - 1)
    +
    +#define AT24CS_SERIAL_SIZE 16
    +#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08)
    +
    struct at24_data {
    struct at24_platform_data chip;
    struct memory_accessor macc;
    @@ -98,14 +106,6 @@ static unsigned write_timeout = 25;
    module_param(write_timeout, uint, 0);
    MODULE_PARM_DESC(write_timeout, "Time (in ms) to try writes (default 25)");

    -#define AT24_SIZE_BYTELEN 5
    -#define AT24_SIZE_FLAGS 8
    -
    -#define AT24_BITMASK(x) (BIT(x) - 1)
    -
    -#define AT24CS_SERIAL_SIZE 16
    -#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08)
    -
    /* create non-zero magic value for given eeprom parameters */
    #define AT24_DEVICE_MAGIC(_len, _flags) \
    ((1 << AT24_SIZE_FLAGS | (_flags)) \
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-10-12 17:01    [W:4.242 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site