Messages in this thread | | | Date | Sun, 11 Oct 2015 19:34:45 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/1] I have a board it block on i8259A_shutdown when I want to poweroff. It is not always re-produce. |
| |
Figo,
On Sat, 10 Oct 2015, Figo wrote:
Thanks for resending, but let me clarify a few things.
Subject line:
[PATCH 1/1] I have a board it block on i8259A_shutdown when I want to poweroff. It is not always re-produce.
That's not a proper patch subject line. It should start with the subsystem and the particular unit in the subsystem you are modifying.
[PATCH] x86/i8259:
The subject itself should contain a short and understandable description of the modification. Something like this:
[PATCH] x86/i8259: Take i8259_lock in i8259A_shutdown()
or
[PATCH] x86/i8259: Prevent race in i8259A_shutdown()
Ok?
That must be followed by an explanation of the problem and how the modification of the code solves it.
Ok?
Aside of that I provided you another example of a problem which is not cured by your patch, but I can't find an answer to that either. I explicitely asked you for more information.
Please always address the questions a reviewer asks you. If the questions are not clear to you, feel free to ask for clarification.
Thanks,
tglx
| |