lkml.org 
[lkml]   [2015]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] misc: mic: use kstrdup() in cosm_sysfs
From
Date
On Sat, 2015-10-10 at 04:46 -0700, Geliang Tang wrote:
> Use kstrdup instead of kmalloc and strncpy.

As count is a function argument, this isn't the same code.

You should state why it's correct in the commit log.

> diff --git a/drivers/misc/mic/cosm/cosm_sysfs.c b/drivers/misc/mic/cosm/cosm_sysfs.c
[]
> @@ -211,18 +211,14 @@ cmdline_store(struct device *dev, struct device_attribute *attr,
> mutex_lock(&cdev->cosm_mutex);
> kfree(cdev->cmdline);
>
> - cdev->cmdline = kmalloc(count + 1, GFP_KERNEL);
> + cdev->cmdline = kstrdup(buf, GFP_KERNEL);




\
 
 \ /
  Last update: 2015-10-10 21:41    [W:0.089 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site