Messages in this thread Patch in this message | | | From | Punit Vara <> | Subject | [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() | Date | Sat, 10 Oct 2015 22:28:40 +0530 |
| |
This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl :
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
bssid has datatype u8 and pnetwork->network.MacAddress has data type unsigned char.
Signed-off-by: Punit Vara <punitvara@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index 2ba055d..1c9092e 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -2007,7 +2007,7 @@ static int r871x_get_ap_info(struct net_device *dev, return -EINVAL; } netdev_info(dev, "r8712u: BSSID:%pM\n", bssid); - if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) { + if (!ether_addr_equal(bssid, pnetwork->network)) { /* BSSID match, then check if supporting wpa/wpa2 */ pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12], &wpa_ielen, pnetwork->network.IELength-12); -- 2.5.3
| |