lkml.org 
[lkml]   [2015]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4] clk: add CS2000 Fractional-N driver
    Date

    Hi Stephen

    Thank you for your review

    > > + init.parent_names = parent_names;
    > > + init.num_parents = ARRAY_SIZE(parent_names);
    > > +
    > > + priv->hw.init = &init;
    > > +
    > > + clk = clk_register(NULL, &priv->hw);
    >
    > How about using devm_clk_register() and passing the i2c device
    > down to this function?

    Can I confirm ?
    Does this "i2c device down" means call i2c_set_clientdata()
    in this function ?

    > > +static int cs2000_clk_init(struct cs2000_priv *priv)
    > > +{
    > > + struct device *dev = priv_to_dev(priv);
    > > + struct device_node *np = dev->of_node;
    > > + u32 rate;
    > > + int ch = 0; /* it uses ch0 only at this point */
    > > + int ret;
    > > +
    > > + if (of_property_read_u32(np, "clock-frequency", &rate))
    >
    > Why can't we do this with DT assigned rates?

    What doesn this "DT assigned rates" mean ?
    this rate will be used as default output


    \
     
     \ /
      Last update: 2015-10-02 03:21    [W:3.143 / U:1.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site