Messages in this thread | | | Date | Thu, 1 Oct 2015 10:50:18 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c |
| |
On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote: > DWC2 module on some platforms needs three additional hardware > resources: phy controller, clock and power supply. All of them must be > enabled/activated to properly initialize and operate. This was initially > handled in s3c-hsotg driver, which has been converted to 'gadget' part > of dwc2 driver. Unfortunately, not all of this code got moved to common > platform code, what resulted in accessing DWC2 registers without > enabling low-level hardware resources. This fails for example on Exynos > SoCs. This patch moves all the code for managing those resources to > common platform.c file and provides convenient wrappers for controlling > them. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
I just caught several build errors which this patch. I hope you can send me a follow-up fix (which I can amend to $subject) otherwise I'll have to drop this series
-- balbi [unhandled content-type:application/pgp-signature] | |