lkml.org 
[lkml]   [2015]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/8] mfd: lm3533: Simplify function return logic
On Tue, 29 Sep 2015, Javier Martinez Canillas wrote:

> The invoked functions already return zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mfd/lm3533-core.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 643f3750e830..193ecee1fa7e 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533,
> if (ret)
> return ret;
>
> - ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
> }
>
> static int lm3533_device_init(struct lm3533 *lm3533)
> @@ -613,11 +609,7 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> lm3533->dev = &i2c->dev;
> lm3533->irq = i2c->irq;
>
> - ret = lm3533_device_init(lm3533);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return lm3533_device_init(lm3533);
> }
>
> static int lm3533_i2c_remove(struct i2c_client *i2c)

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-10-01 09:41    [W:0.486 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site