lkml.org 
[lkml]   [2015]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/16] frv: add struct pci_ops member names to initialization
    Date
    Some instances of pci_ops initialization rely on the read/write members'
    location in the struct. This is fragile and may break when adding new
    members to the beginning of the struct.

    Signed-off-by: Rob Herring <robh@kernel.org>
    Cc: David Howells <dhowells@redhat.com>
    ---
    arch/frv/mb93090-mb00/pci-vdk.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/frv/mb93090-mb00/pci-vdk.c b/arch/frv/mb93090-mb00/pci-vdk.c
    index efa5d65..b073f4d 100644
    --- a/arch/frv/mb93090-mb00/pci-vdk.c
    +++ b/arch/frv/mb93090-mb00/pci-vdk.c
    @@ -168,8 +168,8 @@ static int pci_frv_write_config(struct pci_bus *bus, unsigned int devfn, int whe
    }

    static struct pci_ops pci_direct_frv = {
    - pci_frv_read_config,
    - pci_frv_write_config,
    + .read = pci_frv_read_config,
    + .write = pci_frv_write_config,
    };

    /*
    --
    2.1.0


    \
     
     \ /
      Last update: 2015-01-10 04:01    [W:2.912 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site