Messages in this thread | | | Date | Fri, 09 Jan 2015 18:06:27 -0800 | From | Stephen Boyd <> | Subject | Re: [PATCH 04/10] clocksource: Add max_cycles to clocksource structure |
| |
On 01/09/2015 04:34 PM, John Stultz wrote: > diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h > index abcafaa..9b54cb9 100644 > --- a/include/linux/clocksource.h > +++ b/include/linux/clocksource.h > @@ -178,7 +178,7 @@ struct clocksource { > #ifdef CONFIG_ARCH_CLOCKSOURCE_DATA > struct arch_clocksource_data archdata; > #endif > - > + u64 max_cycles;
Nitpick: Update kernel-doc for new field?
> const char *name; > struct list_head list; > int rating; > @@ -291,7 +291,8 @@ extern struct clocksource * __init clocksource_default_clock(void); > diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c > index c794b84..2910f00 100644 > --- a/kernel/time/sched_clock.c > +++ b/kernel/time/sched_clock.c > @@ -126,7 +126,7 @@ void __init sched_clock_register(u64 (*read)(void), int bits, > new_mask = CLOCKSOURCE_MASK(bits); > > /* calculate how many ns until we risk wrapping */ > - wrap = clocks_calc_max_nsecs(new_mult, new_shift, 0, new_mask); > + wrap = clocks_calc_max_nsecs(new_mult, new_shift, 0, new_mask, 0);
Should be NULL instead of 0? Otherwise I think sparse would complain.
Otherwise:
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |