Messages in this thread | | | From | "" <> | Subject | RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx | Date | Fri, 9 Jan 2015 08:43:29 +0000 |
| |
From: Stefan Agner <stefan@agner.ch> Sent: Friday, January 09, 2015 4:22 PM > To: Duan Fugang-B38611 > Cc: Bhuvanchandra DV; linux-kernel@vger.kernel.org; Zhou Luwei-B45643; > LW@karo-electronics.de; Li Frank-B20596; davem@davemloft.net; u.kleine- > koenig@pengutronix.de; shawn.guo@linaro.org > Subject: RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx > > On 2015-01-09 04:00, fugang.duan@freescale.com wrote: > > From: Stefan Agner <stefan@agner.ch> Sent: Friday, January 09, 2015 > > 2:59 AM > >> To: Duan Fugang-B38611 > >> Cc: Bhuvanchandra DV; linux-kernel@vger.kernel.org; Zhou > >> Luwei-B45643; LW@karo-electronics.de; Li Frank-B20596; > >> davem@davemloft.net; u.kleine- koenig@pengutronix.de; > >> shawn.guo@linaro.org > >> Subject: RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx > >> [snip] > > Currently, MAC1 is broken in case 3 on Vybrid (as well as i.MX6XS and > i.MX7, because the FEC_QUIRK_ENET_MAC is enabled for all of them). > > > For all these cases, your above patches cannot handle these. > > Yes, in it's current state, I agree. A new revision is required. > > > So I still insist to add another property for this to avoid the > > existing dts files change. > > But I don't think adding another device tree property is helping here. > There is already a device tree standard how to describe the MDIO buses, > why not just make use of them? > > I will create a v2 patchset, so we have a new base to discuss this > further. > Don't invent new property, and compatible with above four cases (avoid existing dts changing), it is difficult. Looking forward to your next patchset.
Regards, Andy
| |