Messages in this thread | | | Date | Fri, 9 Jan 2015 11:30:59 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH v2] HID: logitech-hidpp: store the name of the device in struct hidpp |
| |
On Thu, 8 Jan 2015, Benjamin Tissoires wrote:
> If a disconnect occurs while getting the actual name of the device > (which can take several HID transactions), the name of the device will > be the hid name, provided by the Unifying Receiver. > This means that in some cases, the user space will see a different > name that what it usually sees when there is no disconnect. > > We should store the name of the device in the struct hidpp. That way, > if a disconnect occurs while we are accessing the name, > hidpp_connect_event() can fail, and the input node is not created. > > The input node will be created only if we have a connection which > lasts long enough to retrieve all the requested information: > name, protocol, and specific configuration. > > Reviewed-by: Peter Wu <peter@lekensteyn.nl> > Tested-by: Peter Wu <peter@lekensteyn.nl> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied to for-3.20/logitech.
Thanks,
-- Jiri Kosina SUSE Labs
| |