lkml.org 
[lkml]   [2015]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v2 5/5] OOM, PM: make OOM detection in the freezer path raceless
On Wed 07-01-15 13:41:24, Tejun Heo wrote:
> Hello, Michal. Sorry about the long delay.
>
> On Fri, Dec 05, 2014 at 05:41:47PM +0100, Michal Hocko wrote:
> ...
> > @@ -252,6 +220,8 @@ void thaw_kernel_threads(void)
> > {
> > struct task_struct *g, *p;
> >
> > + oom_killer_enable();
> > +
>
> Wouldn't it be more symmetrical and make more sense to enable oom
> killer after kernel threads are thawed? Until kernel threads are
> thawed, it isn't guaranteed that oom killer would be able to make
> forward progress, right?

Makes sense, fixed.

> Other than that, looks good to me.

Thanks! Btw. I plan to repost after Andrew releases new mmotm as there
are some dependencies in oom area.
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2015-01-07 20:01    [W:0.078 / U:7.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site