Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH v2] ath10k: fixup wait_for_completion_timeout return handling | Date | Wed, 7 Jan 2015 19:04:36 +0200 |
| |
Nicholas Mc Guire <der.herr@hofr.at> writes:
> wait_for_completion_timeout does not return negative values so the tests > for <= 0 are not needed and the case differentiation in the error handling > path unnecessary. > > v2: all wait_for_completion_timeout changes in a single patch > > patch was only compile tested x86_64_defconfig + CONFIG_ATH_CARDS=m > CONFIG_ATH10K=m > > patch is against linux-next 3.19.0-rc1 -next-20141226 > > None of the proposed cleanups are critical. > All changes should only be removing unreachable cases. > > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at> > ---
All the comments after "v2:" should be here, under the "---" line so that git-am can automatically discard them.
-- Kalle Valo
| |