lkml.org 
[lkml]   [2015]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 12/38] dm space map metadata: fix sm_bootstrap_get_nr_blocks()
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit c1c6156fe4d4577444b769d7edd5dd503e57bbc9 upstream.

    This function isn't right and it causes a static checker warning:

    drivers/md/dm-thin.c:3016 maybe_resize_data_dev()
    error: potentially using uninitialized 'sb_data_size'.

    It should set "*count" and return zero on success the same as the
    sm_metadata_get_nr_blocks() function does earlier.

    Fixes: 3241b1d3e0aa ('dm: add persistent data library')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Joe Thornber <ejt@redhat.com>
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/persistent-data/dm-space-map-metadata.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/md/persistent-data/dm-space-map-metadata.c
    +++ b/drivers/md/persistent-data/dm-space-map-metadata.c
    @@ -493,7 +493,9 @@ static int sm_bootstrap_get_nr_blocks(st
    {
    struct sm_metadata *smm = container_of(sm, struct sm_metadata, sm);

    - return smm->ll.nr_blocks;
    + *count = smm->ll.nr_blocks;
    +
    + return 0;
    }

    static int sm_bootstrap_get_nr_free(struct dm_space_map *sm, dm_block_t *count)



    \
     
     \ /
      Last update: 2015-01-07 03:01    [W:2.834 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site