lkml.org 
[lkml]   [2015]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute
On Tue, Jan 06, 2015 at 03:29:56PM +0100, Mariusz Gorski wrote:
> Add new attribute to simplify reading of current temperature.
>
> Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
> ---
> drivers/w1/slaves/w1_therm.c | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)

You add sysfs attributes without adding new Documentation/ABI/ entries,
which means I can't take this patch series, sorry. Please redo it and
add the needed information.

Also, temperature should be a standard sensor attribute, so you might
want to use that subsystem instead of creating your own ABI here.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-01-06 19:01    [W:0.097 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site