lkml.org 
[lkml]   [2015]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.19 3/3] x86, mpx: Change the MPX enable/disable API to arch_prctl
On 01/05/2015 03:04 PM, Andy Lutomirski wrote:
>> > Yeah, I'd _really_ prefer not to change it. The code is in a gcc
>> > branch, but is getting pulled in to the 5.0 release. We've got
>> > *absolutely* no shortage of prctl numbers.
> We do, however, have a severe shortage of sanity in the prctl implementation.
>
> Anyway, if it's actually a problem to change it, I have no real
> problem keeping it, but I think we *really* need to validate the rest
> of the arguments at the very least.

Do you mean just adding a pair of

if (arg2 || arg3 || arg4 || arg5)
return -EINVAL;

checks?

That's perfectly fine with me. I'm happy to queue up a patch to do just
that if that's what you're going for.


\
 
 \ /
  Last update: 2015-01-06 00:41    [W:2.121 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site