lkml.org 
[lkml]   [2015]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [2/3] mm: fix up some user-visible effects of the stack guard page
From
On Mon, Jan 5, 2015 at 1:03 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> IOW, *maybe* a patch like this. TOTALLY UNTESTED! I may have missed
> something, and this may be complete crap.

It does indeed seem to work.

But see my other email about this effectively making the stack limit
one page smaller. I'm not entirely sure it's worth fixing, but maybe
in another four years somebody will post a regression email about that
;)

IOW, I'd be inclined to say "stack limit includes guard page", and
just wait and see whether that causes any issues.

But regardless, I'd like you to test the patch in your environment
(with the full real load, not just the demonstration test case), since
you are clearly doing special things. My limited testing was just that
- very limited.

Thanks,

Linus


\
 
 \ /
  Last update: 2015-01-05 22:41    [W:0.062 / U:27.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site