Messages in this thread | | | Date | Mon, 5 Jan 2015 13:19:37 -0800 | Subject | Re: [2/3] mm: fix up some user-visible effects of the stack guard page | From | Linus Torvalds <> |
| |
On Mon, Jan 5, 2015 at 1:03 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > IOW, *maybe* a patch like this. TOTALLY UNTESTED! I may have missed > something, and this may be complete crap.
It does indeed seem to work.
But see my other email about this effectively making the stack limit one page smaller. I'm not entirely sure it's worth fixing, but maybe in another four years somebody will post a regression email about that ;)
IOW, I'd be inclined to say "stack limit includes guard page", and just wait and see whether that causes any issues.
But regardless, I'd like you to test the patch in your environment (with the full real load, not just the demonstration test case), since you are clearly doing special things. My limited testing was just that - very limited.
Thanks,
Linus
| |