lkml.org 
[lkml]   [2015]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue
    On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
    > On 01/04, Piotr Kubus wrote:
    > > This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
    >
    > Nice however improve your commit message. The rule is that the lines
    > should wrap at 72nd column except for quoted material such as compiler
    > output, etc...
    >
    > The 72-character columns are important for allowing quoting and they
    > play nicely with standard indentation from git log.

    Hey,

    I couldn't find that rule in Kernel documentation. Besides there were no
    complaints from checkpatch.pl tool.

    Do you mean I should resend it or wait for reply from maintainer first?

    Regards,
    Piotr

    >
    > Thanks,
    > Konrad
    >
    > > Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com>
    > > ---
    > > drivers/staging/comedi/drivers/dmm32at.c | 2 +-
    > > 1 file changed, 1 insertion(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
    > > index 6df298a..31919b8 100644
    > > --- a/drivers/staging/comedi/drivers/dmm32at.c
    > > +++ b/drivers/staging/comedi/drivers/dmm32at.c
    > > @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
    > > /* enable the ai conversion interrupt and the clock to start scans */
    > > outb(DMM32AT_INTCLK_ADINT |
    > > DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
    > > - dev->iobase + DMM32AT_INTCLK_REG);
    > > + dev->iobase + DMM32AT_INTCLK_REG);
    > > }
    > >
    > > static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
    > > --
    > > 1.9.1
    > >
    > > _______________________________________________
    > > devel mailing list
    > > devel@linuxdriverproject.org
    > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


    \
     
     \ /
      Last update: 2015-01-05 20:41    [W:3.455 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site