lkml.org 
[lkml]   [2015]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [GIT PULL] fuse update for 3.19
From
On Mon, Jan 5, 2015 at 1:11 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Wed, Dec 24, 2014 at 12:53:13PM -0400, Marc Dionne wrote:
>
>> Commit 7078187a795f ("fuse: introduce fuse_simple_request() helper")
>> from the above pull request triggers some EIO errors for me in some
>> tests that rely on fuse.
>>
>> Looking at the code changes and a bit of debugging info I think
>> there's a general problem here that fuse_get_req checks and possibly
>> waits for fc->initialized, and this was always called first. But this
>> commit changes the ordering and in many places fc->minor is now
>> possibly used before fuse_get_req, and we can't be sure that fc has
>> been initialized. In my case fuse_lookup_init sets
>> req->out.args[0].size to the wrong size because fc->minor at that
>> point is still 0, leading to the EIO error.
>>
>> Assuming the analysis makes sense, it wasn't obvious what the best fix
>> should be.
>
> Here's a patch to fix this. Could you please give it a try?
>
> Thanks,
> Miklos

Works fine with my test case that fails on current master.

Thanks,
Marc


\
 
 \ /
  Last update: 2015-01-05 18:41    [W:0.055 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site