lkml.org 
[lkml]   [2015]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 9/13] ALSA: i2sbus: Delete an unnecessary check before the function call "snd_pcm_suspend_all"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 3 Jan 2015 20:43:01 +0100

    The snd_pcm_suspend_all() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    sound/aoa/soundbus/i2sbus/core.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c
    index 4e2b4fb..837ba99 100644
    --- a/sound/aoa/soundbus/i2sbus/core.c
    +++ b/sound/aoa/soundbus/i2sbus/core.c
    @@ -381,10 +381,8 @@ static int i2sbus_suspend(struct macio_dev* dev, pm_message_t state)

    list_for_each_entry(i2sdev, &control->list, item) {
    /* Notify Alsa */
    - if (i2sdev->sound.pcm) {
    - /* Suspend PCM streams */
    - snd_pcm_suspend_all(i2sdev->sound.pcm);
    - }
    + /* Suspend PCM streams */
    + snd_pcm_suspend_all(i2sdev->sound.pcm);

    /* Notify codecs */
    list_for_each_entry(cii, &i2sdev->sound.codec_list, list) {
    --
    2.2.1


    \
     
     \ /
      Last update: 2015-01-04 14:41    [W:4.021 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site