lkml.org 
[lkml]   [2015]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 5/13] ALSA: emux: Delete an unnecessary check before the function call "snd_sf_free"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 3 Jan 2015 18:28:21 +0100

    The snd_sf_free() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    sound/synth/emux/emux.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/sound/synth/emux/emux.c b/sound/synth/emux/emux.c
    index 9352207..f27a1c8 100644
    --- a/sound/synth/emux/emux.c
    +++ b/sound/synth/emux/emux.c
    @@ -160,12 +160,8 @@ int snd_emux_free(struct snd_emux *emu)
    snd_emux_detach_seq_oss(emu);
    #endif
    snd_emux_detach_seq(emu);
    -
    snd_emux_delete_hwdep(emu);
    -
    - if (emu->sflist)
    - snd_sf_free(emu->sflist);
    -
    + snd_sf_free(emu->sflist);
    kfree(emu->voices);
    kfree(emu->name);
    kfree(emu);
    --
    2.2.1


    \
     
     \ /
      Last update: 2015-01-04 14:21    [W:4.160 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site