lkml.org 
[lkml]   [2015]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/13] ALSA: oss: Deletion of unnecessary checks before the function call "vfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 3 Jan 2015 15:10:52 +0100

    The vfree() function performs also input parameter validation. Thus the test
    around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    sound/oss/pss.c | 2 +-
    sound/oss/trix.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/oss/pss.c b/sound/oss/pss.c
    index ca0d6e9..81314f9 100644
    --- a/sound/oss/pss.c
    +++ b/sound/oss/pss.c
    @@ -1228,7 +1228,7 @@ static void __exit cleanup_pss(void)
    {
    if(!pss_no_sound)
    {
    - if(fw_load && pss_synth)
    + if (fw_load)
    vfree(pss_synth);
    if(pssmss)
    unload_pss_mss(&cfg2);
    diff --git a/sound/oss/trix.c b/sound/oss/trix.c
    index 944e0c0..3c494dc 100644
    --- a/sound/oss/trix.c
    +++ b/sound/oss/trix.c
    @@ -487,7 +487,7 @@ static int __init init_trix(void)

    static void __exit cleanup_trix(void)
    {
    - if (fw_load && trix_boot)
    + if (fw_load)
    vfree(trix_boot);
    if (sb)
    unload_trix_sb(&cfg2);
    --
    2.2.1


    \
     
     \ /
      Last update: 2015-01-04 14:01    [W:4.243 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site