lkml.org 
[lkml]   [2015]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions
On 01/03/2015 06:47 PM, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> dma_txflush() dma_txsuspended()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/dma.c | 19 -------------------
> drivers/net/wireless/brcm80211/brcmsmac/dma.h | 2 --
> 2 files changed, 21 deletions(-)

Just because file dma.c is involved, it does not need to be, nor should it be in
the subject line. You could specify the driver names in the file tree after
wireless. In this instance, one possible subject would be "brcm80211: brcmsmac:
Remove some unused functions". On the other hand, if you look at "git log" to
see past patches, the driver maintainers even leave off the brcm80211 part, thus
to match them, the subject should be "brcmsmac: Remove some unused functions".

As was suggested earlier, you need to look at the precedents. Keeping a uniform
method of patch naming helps when looking for patches in the git log.

Larry




\
 
 \ /
  Last update: 2015-01-04 08:01    [W:0.073 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site