lkml.org 
[lkml]   [2015]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8192e: Fix duplicated conditional branch
On 01/04/2015 01:10 AM, Joe Perches wrote:
> On Sun, 2015-01-04 at 12:59 +0600, Alexander Kuleshov wrote:
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> []
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> []
>> @@ -1661,7 +1661,7 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev,
>> dm_digtable.rssi_low_thresh = dm_value;
>> } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>> dm_digtable.rssi_high_power_highthresh = dm_value;
>> - } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>> + } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
>> dm_digtable.rssi_high_power_highthresh = dm_value;
>> } else if (dm_type == DIG_TYPE_ENABLE) {
>> dm_digtable.dig_state = DM_STA_DIG_MAX;
>
> Presumably, this is a copy/paste error and should have
> both lines changed to HIGHPWR_LOW/high_power_lowthresh
>
> else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW)
> dm_digtable.rssi_high_power_lowthresh = dm_value;
>

I have no idea what this should be, but this patch does not appear to be any
improvement. Joe is probably correct.

Larry




\
 
 \ /
  Last update: 2015-01-05 03:01    [W:1.768 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site