Messages in this thread Patch in this message | | | Date | Sat, 31 Jan 2015 04:04:14 +0200 | From | Heba Aamer <> | Subject | [PATCH] checkpatch: enhance check for seq_printf uses that could be seq_puts |
| |
This patch enhances the check for seq_printf uses that could be seq_puts.
It was considering the escape of % is \%, but it is %%. This led to skipping some valid cases related to that warning.
Signed-off-by: Heba Aamer <heba93aamer@gmail.com> --- scripts/checkpatch.pl | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f0bb6d6..0b125ca 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4804,11 +4804,14 @@ sub process { # check for seq_printf uses that could be seq_puts if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) { my $fmt = get_quoted_string($line, $rawline); - if ($fmt ne "" && $fmt !~ /[^\\]\%/) { - if (WARN("PREFER_SEQ_PUTS", - "Prefer seq_puts to seq_printf\n" . $herecurr) && - $fix) { - $fixed[$fixlinenr] =~ s/\bseq_printf\b/seq_puts/; + if ($fmt ne "") { + $fmt =~ s/%%//g; + if ($fmt !~ /%/) { + if (WARN("PREFER_SEQ_PUTS", + "Prefer seq_puts to seq_printf\n" . $herecurr) && + $fix) { + $fixed[$fixlinenr] =~ s/\bseq_printf\b/seq_puts/; + } } } } -- 1.7.9.5
| |