lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] clk: remove clk-private.h
    On 01/30/15 13:25, Michael Turquette wrote:
    > Private clock framework data structures should be private, surprisingly.
    >
    > Now that all platforms and drivers have been updated to remove static
    > initializations of struct clk and struct clk_core objects and all
    > references to clk-private.h have been removed we can move the
    > definitions of these structures into drivers/clk/clk.c and delete the
    > header.
    >
    > Additionally the ugly DEFINE_CLK macros have been removed. Those were
    > used for static definitions of struct clk objects. That practice is no
    > longer allowed.
    >
    > Signed-off-by: Michael Turquette <mturquette@linaro.org>

    This is great!

    Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

    given the minor comment below.

    > - * Returns 0 on success, otherwise an error code.
    > - */
    > -int __clk_init(struct device *dev, struct clk *clk);

    Shouldn't __clk_init become static now in clk.c?

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project



    \
     
     \ /
      Last update: 2015-01-31 01:01    [W:3.302 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site