lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch v2 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing
On 01/30/15 08:32, Kumar Gala wrote:
> On Jan 30, 2015, at 12:25 AM, Andy Gross <agross@codeaurora.org> wrote:
>
>> Required properties if child node exists:
>> - #address-cells: Must be 1
>> - #size-cells: Must be 1
>> - ranges: Must be present
>>
>> +Note: Each GSBI should have an alias correctly numbered in "aliases" node.
>> +
>> Properties for children:
>>
>> A GSBI controller node can contain 0 or more child nodes representing serial
>> @@ -37,6 +41,10 @@ Example for APQ8064:
>>
>> #include <dt-bindings/soc/qcom,gsbi.h>
>>
>> + aliases {
>> + gsbi4 = <&gsbi4>;
>> + };
> You appear to be using the alias name to determine a index number for the gsbi, if that is the case, than you should probably just add a cell-index node to the gsbi’s for this purpose.
>

I thought cell-index was "deprecated" and referred more to things like
enumerating all the devices on a bus by assigning them a unique ID.
Aliases, on the other hand, allow us to enumerate a subset of devices
that share the same bus with other devices of different types. For
example, how would I know that a device is gsbi1 vs serial1 if they both
used cell-index and they both had the same parent node?

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project



\
 
 \ /
  Last update: 2015-01-30 22:41    [W:0.110 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site