lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 1/3] xen: mark pvscsi frontend request consumed only after last read
On 01/30/2015 12:47 PM, Jan Beulich wrote:
>>>> On 30.01.15 at 12:21, <JGross@suse.com> wrote:
>> @@ -734,11 +734,11 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info)
>> if (!pending_req)
>> return 1;
>>
>> - ring_req = RING_GET_REQUEST(ring, rc);
>> + memcpy(&ring_req, RING_GET_REQUEST(ring, rc), sizeof(ring_req));
>
> I'd recommend the type safe *ring_req = *RING_GET_REQUEST(ring, rc)
> here.

I think I'll use ring_req = *RING_GET_REQUEST(ring, rc) :-)

>
>> ring->req_cons = ++rc;
>>
>> - act = ring_req->act;
>> - err = prepare_pending_reqs(info, ring_req, pending_req);
>> + act = ring_req.act;
>
> Is this helper variable then still needed?

No, you're right. Will delete it.


Juergen


\
 
 \ /
  Last update: 2015-01-30 13:41    [W:0.073 / U:1.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site