lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: comedi: drivers: usbduxsigma: Removed variables that is never used
On 29/01/15 22:50, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/usbduxsigma.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
> index dc19435..185f2d1 100644
> --- a/drivers/staging/comedi/drivers/usbduxsigma.c
> +++ b/drivers/staging/comedi/drivers/usbduxsigma.c
> @@ -215,7 +215,6 @@ static void usbduxsigma_ai_handle_urb(struct comedi_device *dev,
> struct usbduxsigma_private *devpriv = dev->private;
> struct comedi_async *async = s->async;
> struct comedi_cmd *cmd = &async->cmd;
> - unsigned int dio_state;
> uint32_t val;
> int ret;
> int i;
> @@ -224,9 +223,6 @@ static void usbduxsigma_ai_handle_urb(struct comedi_device *dev,
> if (devpriv->ai_counter == 0) {
> devpriv->ai_counter = devpriv->ai_timer;
>
> - /* get the state of the dio pins to allow external trigger */
> - dio_state = be32_to_cpu(devpriv->in_buf[0]);
> -
> /* get the data from the USB bus and hand it over to comedi */
> for (i = 0; i < cmd->chanlist_len; i++) {
> /* transfer data, note first byte is the DIO state */
>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-01-30 12:01    [W:0.050 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site