lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: comedi: drivers: rtd520: Removed variables that is never used
On 29/01/15 22:43, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/rtd520.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
> index 581aa58..1130bf0 100644
> --- a/drivers/staging/comedi/drivers/rtd520.c
> +++ b/drivers/staging/comedi/drivers/rtd520.c
> @@ -1031,8 +1031,6 @@ static int rtd_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> static int rtd_ai_cancel(struct comedi_device *dev, struct comedi_subdevice *s)
> {
> struct rtd_private *devpriv = dev->private;
> - u32 overrun;
> - u16 status;
>
> /* pacer stop source: SOFTWARE */
> writel(0, dev->mmio + LAS0_PACER_STOP);
> @@ -1040,8 +1038,6 @@ static int rtd_ai_cancel(struct comedi_device *dev, struct comedi_subdevice *s)
> writel(0, dev->mmio + LAS0_ADC_CONVERSION);
> writew(0, dev->mmio + LAS0_IT);
> devpriv->ai_count = 0; /* stop and don't transfer any more */
> - status = readw(dev->mmio + LAS0_IT);
> - overrun = readl(dev->mmio + LAS0_OVERRUN) & 0xffff;
> writel(0, dev->mmio + LAS0_ADC_FIFO_CLEAR);
> return 0;
> }
>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-01-30 12:01    [W:0.048 / U:2.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site