Messages in this thread | | | Date | Fri, 30 Jan 2015 10:33:12 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH v2] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used |
| |
On 29/01/15 22:40, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/staging/comedi/drivers/dyna_pci10xx.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c > index 1b6324c..56490f4 100644 > --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c > +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c > @@ -1,4 +1,4 @@ > -/* > +_/*
Something went wrong there. :)
> * comedi/drivers/dyna_pci10xx.c > * Copyright (C) 2011 Prashant Shah, pshah.mumbai@gmail.com > * > @@ -115,10 +115,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev, > { > struct dyna_pci10xx_private *devpriv = dev->private; > int n; > - unsigned int chan, range; > - > - chan = CR_CHAN(insn->chanspec); > - range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))]; > > mutex_lock(&devpriv->mutex); > for (n = 0; n < insn->n; n++) { >
That part is good.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |