lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] KVM: x86: return bool from kvm_apic_match*()


On 29/01/2015 23:10, Joe Perches wrote:
> On Thu, 2015-01-29 at 22:48 +0100, Radim Krčmář wrote:
>> And don't export the internal ones while at it.
> []
>> -int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda)
>> +static bool kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda)
>> {
>> int result = 0;
>> u32 logical_id;
>> @@ -626,7 +626,7 @@ int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda)
>> return result;
>> }
>>
>> -int kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source,
>> +bool kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source,
>> int short_hand, unsigned int dest, int dest_mode)
>> {
>> int result = 0;
>
> Perhaps these result variables should be bool.

See patch 2.

Paolo


\
 
 \ /
  Last update: 2015-01-30 10:01    [W:0.055 / U:3.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site