lkml.org 
[lkml]   [2015]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drm/radeon: do not left queue acquired if timeout happens in kgd_hqd_destroy()
    Date
    If timeout happens, kgd_hqd_destroy() just returns -ETIME leaving queue acquired.
    It may cause a deadlock, so the patch proposes to release queue before return.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    ---
    drivers/gpu/drm/radeon/radeon_kfd.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
    index 242fd8b1b221..335e29dbab05 100644
    --- a/drivers/gpu/drm/radeon/radeon_kfd.c
    +++ b/drivers/gpu/drm/radeon/radeon_kfd.c
    @@ -556,6 +556,7 @@ static int kgd_hqd_destroy(struct kgd_dev *kgd, uint32_t reset_type,
    if (timeout == 0) {
    pr_err("kfd: cp queue preemption time out (%dms)\n",
    temp);
    + release_queue(kgd);
    return -ETIME;
    }
    msleep(20);
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-01-04 00:41    [W:4.377 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site