Messages in this thread | | | From | Chao Yu <> | Subject | RE: [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super | Date | Thu, 29 Jan 2015 19:24:59 +0800 |
| |
Hi Jaegeuk,
> -----Original Message----- > From: linux-fsdevel-owner@vger.kernel.org [mailto:linux-fsdevel-owner@vger.kernel.org] On > Behalf Of Jaegeuk Kim > Sent: Wednesday, January 28, 2015 7:32 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super > > If wrong mount option was requested, f2fs tries to fill_super again. > But, during the next trial, f2fs has no valid mount options, since > parse_options deleted all the separators in the original string.
Nice catch!
But couldn't we encounter memory leak for options if we did not fail to fill super.
Thanks,
| |