Messages in this thread | | | From | Wincy Van <> | Date | Thu, 29 Jan 2015 13:31:45 +0800 | Subject | Re: [PATCH v4 0/6] KVM: nVMX: Enable nested apicv support |
| |
On Thu, Jan 29, 2015 at 11:17 AM, Zhang, Yang Z <yang.z.zhang@intel.com> wrote: > Wincy Van wrote on 2015-01-28: >> v1 ---> v2: >> Use spin lock to ensure vmcs12 is safe when doing nested >> posted interrupt delivery. >> v2 ---> v3: >> 1. Add a new field in nested_vmx to avoid the spin lock in v2. >> 2. Drop send eoi to L1 when doing nested interrupt delivery. >> 3. Use hardware MSR bitmap to enable nested virtualize x2apic >> mode. >> v3 ---> v4: >> 1. Optimize nested msr bitmap merging. >> 2. Allocate nested msr bitmap only when nested == 1. >> 3. Inline the nested vmx control checking functions. > > This version looks good to me. Only minor comment: EXIT_REASON_APIC_WRITE vmexit is introduced by apic register virtualization not virtual interrupt delivery, so it's better add it in 4th patch not 5th patch.(If no other comments, I guess Paolo can help do it when applying it). > > Reviewed-by: Yang Zhang <yang.z.zhang@intel.com> >
Yes, thank you for pointing out it ; ) Paolo, what's your opinion?
Thanks, Wincy
| |