lkml.org 
[lkml]   [2015]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips
Hi Clement,

On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perrochaud@effinnov.com wrote:
> @@ -686,7 +686,7 @@ L: alsa-devel@alsa-project.org (moderated for non-subscribers)
> W: http://blackfin.uclinux.org/
> S: Supported
> F: sound/soc/blackfin/*
> -
> +
Unneeded change, please remove it.

> +config NFC_NXP_NCI
> + tristate "NXP-NCI NFC driver"
> + depends on NFC_NCI
> + default n
> + ---help---
> + Generic core driver for NXP NCI chips.
It usually is nice to be more specific and describe which chipsets
(e.g. NPC100) this driver supports among all the NXP NCI chipsets.

> +struct nxp_nci_phy_ops {
> + int (*enable)(void *id);
> + int (*fw_enable)(void *id);
Wouldn't a int (*enable)(void *id, enum nxp_nci_mode mode); hook be
enough ?

Cheers,
Samuel.


\
 
 \ /
  Last update: 2015-01-30 01:21    [W:0.086 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site