Messages in this thread | | | Date | Wed, 28 Jan 2015 09:42:22 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2] gpio: sysfs: fix gpio device-attribute leak |
| |
On Wed, Jan 28, 2015 at 05:05:05PM +0100, Johan Hovold wrote: > commit 0915e6feb38de8d3601819992a5bd050201a56fa upstream. > > The gpio device attributes were never destroyed when the gpio was > unexported (or on export failures). > > Use device_create_with_groups() to create the default device attributes > of the gpio class device. Note that this also fixes the > attribute-creation race with userspace for these attributes. > > Remove contingent attributes in export error path and on unexport. > > Fixes: d8f388d8dc8d ("gpio: sysfs interface") > Cc: stable <stable@vger.kernel.org> # v2.6.27+ > Signed-off-by: Johan Hovold <johan@kernel.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > > Backport to v3.10 (and earlier) which lacks device_create_with_groups(). > > Changes since v1 > - fix mistake in backport, which removed the attributes while holding > the mutex in gpiod_unexport (reported by Luis Henriques)
Thanks for the updated patch, now replaced the old one with this one.
greg k-h
| |