lkml.org 
[lkml]   [2015]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver
    * Roger Quadros <rogerq@ti.com> [150128 04:15]:
    > On 28/01/15 04:19, Chanwoo Choi wrote:
    > >>
    > >> I still fail to understand that we need to call disable_irq() in .suspend() and
    > >> enable_irq() in .resume()
    > >>
    > >> can you point me to any other drivers doing so?
    > >
    > > You can refer the suspend function in drivers/mfd/max14577.c or drivers/mfd/max77693.c.
    > > The max14577_suspend() includes the detailed comment for why using disable_irq() in suspend function.
    > >
    > > In max14577 case, max14577_suspend() use disable_irq() function because of i2c dependency.
    > > If max14577 device is wake-up from suspend state before completing the resume sequence
    > > of i2c, max14577 may fail to read/write i2c communication.
    >
    > Thanks for this information. I will add disable/enable_irq() in suspend/resume().

    Are the .dts changes safe for me to apply already?

    Regards,

    Tony


    \
     
     \ /
      Last update: 2015-01-28 23:01    [W:2.810 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site