lkml.org 
[lkml]   [2015]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] zram: remove init_lock in zram_make_request
On (01/28/15 23:56), Sergey Senozhatsky wrote:
> > -static inline int init_done(struct zram *zram)
> > +static inline bool init_done(struct zram *zram)
> > {
> > - return zram->meta != NULL;
> > + /*
> > + * init_done can be used without holding zram->init_lock in
> > + * read/write handler(ie, zram_make_request) but we should make sure
> > + * that zram->init_done should set up after meta initialization is
> > + * done. Look at setup_init_done.
> > + */
> > + bool ret = zram->init_done;
>
> I don't like re-introduced ->init_done.
> another idea... how about using `zram->disksize == 0' instead of
> `->init_done' (previously `->meta != NULL')? should do the trick.
>

a typo, I meant `->disksize != 0'.

-ss


\
 
 \ /
  Last update: 2015-01-28 22:01    [W:0.105 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site