Messages in this thread | | | Subject | Re: [PATCH 0/6] Fix fbtft/fb_pcd8544.c coding style errors | From | Joe Perches <> | Date | Tue, 27 Jan 2015 12:47:31 -0800 |
| |
On Tue, 2015-01-27 at 22:30 +0200, Heba Aamer wrote: > This patch set fixes most of the checkpatch.pl coding > style errors found in drivers/staging/fbtft/fb_pcd8544.c > > Heba Aamer (6): > staging: fbtft: fix space required after that ';' > staging: fbtft: fix spaces required around that '=' > staging: fbtft: fix spaces required around that '<'
I suppose this is OK, but I think it's better to do all the horizontal whitespace changes in the same patch.
It's trivial and easy to verify all-at-once instead of modifying the same line multiple times.
It's also nice to say that git diff -w shows no difference and that objdiff is empty.
> staging: fbtft: fix trailing whitespace
| |