Messages in this thread | | | Date | Tue, 27 Jan 2015 17:27:05 +0100 | From | Jesper Nilsson <> | Subject | Re: [PATCH v2 06/40] cris/uaccess: fix sparse errors |
| |
On Tue, Jan 06, 2015 at 04:43:50PM +0100, Michael S. Tsirkin wrote: > virtio wants to read bitwise types from userspace using get_user. At the > moment this triggers sparse errors, since the value is passed through an > integer. > > Fix that up using __force.
Looks sane, I'll take this in the CRIS tree since you have a cleanup patch which depends on it.
Thanks!
/Jesper
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > arch/cris/include/asm/uaccess.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/cris/include/asm/uaccess.h b/arch/cris/include/asm/uaccess.h > index 9145408..9cf5a23 100644 > --- a/arch/cris/include/asm/uaccess.h > +++ b/arch/cris/include/asm/uaccess.h > @@ -153,7 +153,7 @@ struct __large_struct { unsigned long buf[100]; }; > ({ \ > long __gu_err, __gu_val; \ > __get_user_size(__gu_val,(ptr),(size),__gu_err); \ > - (x) = (__typeof__(*(ptr)))__gu_val; \ > + (x) = (__force __typeof__(*(ptr)))__gu_val; \ > __gu_err; \ > }) > > @@ -163,7 +163,7 @@ struct __large_struct { unsigned long buf[100]; }; > const __typeof__(*(ptr)) *__gu_addr = (ptr); \ > if (access_ok(VERIFY_READ,__gu_addr,size)) \ > __get_user_size(__gu_val,__gu_addr,(size),__gu_err); \ > - (x) = (__typeof__(*(ptr)))__gu_val; \ > + (x) = (__force __typeof__(*(ptr)))__gu_val; \ > __gu_err; \ > }) > > -- > MST
/^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com
| |