Messages in this thread | | | Date | Tue, 27 Jan 2015 09:20:47 -0600 | From | Felipe Balbi <> | Subject | Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset |
| |
On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: > A reset through a GPIO is optional. Don't fail probing when it is > missing. > > Reported-by: Andreas Färber <afaerber@suse.de> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > --- > Hi Andreas, > > does this do the trick? > > Thanks, > Sören > > drivers/usb/phy/phy-generic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c > index dd05254241fb..a73d4c738f0b 100644 > --- a/drivers/usb/phy/phy-generic.c > +++ b/drivers/usb/phy/phy-generic.c > @@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop, > > if (err == -EPROBE_DEFER) > return -EPROBE_DEFER; > - if (err) { > - dev_err(dev, "Error requesting RESET GPIO\n"); > - return err; > - } > + if (err) > + nop->gpiod_reset = NULL;
there's a better patch to use gpiod_get_optional(), instead.
-- balbi [unhandled content-type:application/pgp-signature] | |