Messages in this thread | | | Date | Tue, 27 Jan 2015 19:00:19 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] OMAPDSS: hdmi5: remove unneeded check |
| |
On Mon, Jan 26, 2015 at 02:41:42PM +0200, Tomi Valkeinen wrote: > On 13/01/15 18:46, Sudip Mukherjee wrote: > > prior to this check we are checking for word_length_16b and if word_length_16b > > is false then we are returning with -EINVAL. > > So at this point word_length_16b can only be true. > > True, but it looks to me the code may be extended in the future. > > And if it would be clear that it won't be extended in the future, then > there's more code changes needed to reflect that (the whole > word_length_16b can be removed, etc).
you are the author of the code, so you will know if it will be extended .. :)
Sudip > > Tomi > >
| |