lkml.org 
[lkml]   [2015]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: qcom: enable generic support and input-enable pinctrl conf
On 01/27/2015 03:23 AM, Stephen Boyd wrote:
> On 01/26/15 17:18, Stephen Boyd wrote:
>> On 01/26/15 08:24, Stanimir Varbanov wrote:
>>
>>> return -ENOTSUPP;
>>> }
>>>
>>> @@ -208,14 +208,12 @@ static int msm_config_get(struct pinctrl_dev *pctldev,
>>> unsigned int pin,
>>> unsigned long *config)
>>> {
>>> - dev_err(pctldev->dev, "pin_config_set op not supported\n");
>> Same for here.
>>
>>> return -ENOTSUPP;
>>> }
>>>
>>> static int msm_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
>>> unsigned long *configs, unsigned num_configs)
>>> {
>>> - dev_err(pctldev->dev, "pin_config_set op not supported\n");
>> And here.
>
> Actually it looks like we can just remove these two functions and the
> core does the right thing and prints errors. That would be a good patch.
>

Agreed.

--
regards,
Stan


\
 
 \ /
  Last update: 2015-01-27 14:41    [W:0.094 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site