Messages in this thread | | | Date | Tue, 27 Jan 2015 13:02:49 +0100 | From | Alexander Holler <> | Subject | Re: [PATCH] mmc: print message if a card supports secure erase/trim |
| |
Am 27.01.2015 um 12:55 schrieb Richard Weinberger: > On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler <holler@ahsoftware.de> wrote: >> It's an interesting detail, so inform the user about it. >> >> Signed-off-by: Alexander Holler <holler@ahsoftware.de> >> --- >> drivers/mmc/core/bus.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c >> index 8a1f124..4a60028 100644 >> --- a/drivers/mmc/core/bus.c >> +++ b/drivers/mmc/core/bus.c >> @@ -347,6 +347,10 @@ int mmc_add_card(struct mmc_card *card) >> uhs_bus_speed_mode, type, card->rca); >> } >> >> + if (mmc_can_secure_erase_trim(card)) >> + pr_info("%s: card supports secure erase/trim\n", >> + mmc_hostname(card->host)); >> + > > Please make this a sysfs attribute. > Exposing such properties as log messages is horrible.
Look at the source at the message which is printed just before and decide which one you find more informational / useful.
Alexander Holler
| |