lkml.org 
[lkml]   [2015]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 175/177] mm: Remove false WARN_ON from pagecache_isize_extended()
    Date
    From: Jan Kara <jack@suse.cz>

    3.4.106-rc1 review patch. If anyone has any objections, please let me know.

    ------------------


    commit f55fefd1a5a339b1bd08c120b93312d6eb64a9fb upstream.

    The WARN_ON checking whether i_mutex is held in
    pagecache_isize_extended() was wrong because some filesystems (e.g.
    XFS) use different locks for serialization of truncates / writes. So
    just remove the check.

    Signed-off-by: Jan Kara <jack@suse.cz>
    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    Signed-off-by: Dave Chinner <david@fromorbit.com>
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    ---
    mm/truncate.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/mm/truncate.c b/mm/truncate.c
    index 708a499..57625f7 100644
    --- a/mm/truncate.c
    +++ b/mm/truncate.c
    @@ -607,7 +607,6 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
    struct page *page;
    pgoff_t index;

    - WARN_ON(!mutex_is_locked(&inode->i_mutex));
    WARN_ON(to > inode->i_size);

    if (from >= to || bsize == PAGE_CACHE_SIZE)
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-01-28 05:41    [W:2.971 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site