Messages in this thread | | | Date | Mon, 26 Jan 2015 21:34:19 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 00/16 v3] tracing: Add new file system tracefs |
| |
On Mon, 26 Jan 2015 18:37:39 -0500 Steven Rostedt <rostedt@goodmis.org> wrote:
> > the first call of tracing_init_dentry(). Prior to that it's NULL. > > BTW, may I politely inquire what the fuck are those contortions in > > tracing_init_dentry_tr() about? Looks like a stunningly convoluted > > way to trigger that automount point creation early in > > tracer_init_tracefs(). Why not do that right there explicitly? > > Yeah, that could be cleaned up. Before the tracefs code, it made much > more sense to keep that as a single function. Now that > global_array.dir is treated differently as the subdirs, it does make > sense to have global_arry.dir initialized in a separate function. > > I'll update my patch series to do this.
Now I remember why I did this (as I changed the code and everything blew up). The files in the tracing directory can be created by several users (do a grep for fs_initcall() in kernel/trace/*.c). The first caller to add a file initializes the tracing directory.
I guess I can have all the other callers use fs_initcall_sync(). I'm assuming those come after fs_initcall().
-- Steve
| |