lkml.org 
[lkml]   [2015]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 1/7] mm: Change __get_vm_area_node() to use fls_long()
    Date
    __get_vm_area_node() takes unsigned long size, which is a 64-bit
    value on a 64-bit kernel. However, fls(size) simply ignores the
    upper 32-bit. Change to use fls_long() to handle the size properly.

    Signed-off-by: Toshi Kani <toshi.kani@hp.com>
    ---
    mm/vmalloc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/mm/vmalloc.c b/mm/vmalloc.c
    index 39c3388..830a4be 100644
    --- a/mm/vmalloc.c
    +++ b/mm/vmalloc.c
    @@ -29,6 +29,7 @@
    #include <linux/atomic.h>
    #include <linux/compiler.h>
    #include <linux/llist.h>
    +#include <linux/bitops.h>

    #include <asm/uaccess.h>
    #include <asm/tlbflush.h>
    @@ -1314,7 +1315,8 @@ static struct vm_struct *__get_vm_area_node(unsigned long size,

    BUG_ON(in_interrupt());
    if (flags & VM_IOREMAP)
    - align = 1ul << clamp(fls(size), PAGE_SHIFT, IOREMAP_MAX_ORDER);
    + align = 1ul << clamp((int)fls_long(size),
    + PAGE_SHIFT, IOREMAP_MAX_ORDER);

    size = PAGE_ALIGN(size);
    if (unlikely(!size))

    \
     
     \ /
      Last update: 2015-01-27 00:41    [W:3.932 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site