Messages in this thread | | | Date | Mon, 26 Jan 2015 14:37:26 +0200 | From | Tomi Valkeinen <> | Subject | Re: [PATCH] video: fbdev: sis: remove unused variables |
| |
On 22/01/15 17:31, Sudip Mukherjee wrote: > removed some variables which were not used. Few calls to SiS_GetReg() > were left behind as they are reading from the hardare, removing them > might affect the overall functionality. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > This patch will generate checkpatch error, to fix that error we need > to change the style of init.c and init301.c > > drivers/video/fbdev/sis/init.c | 33 +++++---------------------------- > drivers/video/fbdev/sis/init301.c | 10 ++-------- > drivers/video/fbdev/sis/sis_main.c | 9 ++++----- > 3 files changed, 11 insertions(+), 41 deletions(-)
Are you able to test this?
The patch doesn't look too complex, but it's still slightly too complex for me to comfortably merge it without any testing.
Tomi
[unhandled content-type:application/pgp-signature] | |