lkml.org 
[lkml]   [2015]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] video: fbdev: sis: remove unused variables
On 22/01/15 17:31, Sudip Mukherjee wrote:
> removed some variables which were not used. Few calls to SiS_GetReg()
> were left behind as they are reading from the hardare, removing them
> might affect the overall functionality.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> This patch will generate checkpatch error, to fix that error we need
> to change the style of init.c and init301.c
>
> drivers/video/fbdev/sis/init.c | 33 +++++----------------------------
> drivers/video/fbdev/sis/init301.c | 10 ++--------
> drivers/video/fbdev/sis/sis_main.c | 9 ++++-----
> 3 files changed, 11 insertions(+), 41 deletions(-)

Are you able to test this?

The patch doesn't look too complex, but it's still slightly too complex
for me to comfortably merge it without any testing.

Tomi


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-01-26 13:41    [W:0.355 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site